4.1. SCR for ARMI 0.6.0
This is a listing of all the Software Change Request (SCR) changes in the ARMI repository, as part of release number 0.6.0.
Please note that the Software Test Report (STR) documents for all of the changes listed below will be updated as part of this release. This is a necessary part of every ARMI release, that the STRs are all updated.
Below, this SCR is organized into the individual changes that comprise the net SCR for this release.
4.1.1. SCR Listing
The following tables list all the SCRs in this release of the ARMI framework.
Title |
Change |
Impact on
Requirements
|
Author |
Reviewer(s) |
PR |
---|---|---|---|---|---|
Providing better composite iteration methods |
Provide ways for users and developers to traverse the composite tree without using lists. |
This very slightly simplifies the implementation I_ARMI_FLUX_COUPLING_VALUE, and very slightly touches the test T_ARMI_FLUX_COUPLING_VALUE. This also, very slightly, simplifies the implementation I_ARMI_ASSEM_DIMS1 and I_ARMI_CMP1 with the new tools this PR provides. |
Drew Johnson |
John Stilley |
2031 |
Adding a check on the grid/component consistency in the BPs |
Adds a check on the grids associated with a block to ensure that the components that are supposed to be in the grid actually are, and in the correct number. |
This change very slightly touches the unit test T_ARMI_BP_GRID0 for the requirement R_ARMI_BP_GRID. |
Chris Keckler |
John Stilley |
2045 |
Allowing ARMI to use tmp dir on Mac/Linux |
Moving from the home directory to the temp direction on Linux, for ARMI temp files. |
NA |
John Stilley |
Arrielle Opotowsky |
2092 |
Removing support for XML geom files |
Removing support for archaic XML “geom files”, in favor of modern YAML blueprint files. |
NA |
John Stilley |
Arrielle Opotowsky |
2105 |
Add Core.iterBlocks and Assembly.iterBlocks |
Adding Core.iterBlocks and Asssembly.iterBlocks for traversing grandchildren of a Core. |
A trivial implementation change to switch from getBlocks to iterBlocks in the tests for T_ARMI_MACRO_XS, T_ARMI_UMC_PARAM_BACKWARD0, T_ARMI_UMC_PARAM_BACKWARD1, T_ARMI_ROTATE_HEX_ASSEM, T_ARMI_ASSEM_BLOCKS, T_ARMI_R_SYMM, and T_ARMI_ADD_EDGE_ASSEMS. |
Drew Johnson |
John Stilley |
2106 |
Handing empty string defaults better in copyInterfaceInputs |
Adding logic to copyInterfaceInputs to properly handle a file setting default that is an empty string. |
NA |
Arrielle Opotowsky |
John Stilley |
2107 |
Allowing component area to be queried at arbitrary temp |
Allow calculation of component area at arbitrary temperature |
NA |
Alex James |
John Stilley |
2114 |
Adding a FilletedHexagon shape |
Adding a FilletedHexagon shape, which is just a hexagon with rounded corners. |
NA |
John Stilley |
dlangewisch, Chris Keckler, Alex James |
2118 |
Supporting growing DBto full core on db load |
The setting growToFullCoreAfterLoad is used to expand the reactor to full core when loading from a database. |
Functionality added to I_ARMI_DB_TIME1 the implementation of R_ARMI_DB_TIME |
Drew Johnson |
John Stilley |
2121 |
Title |
Change |
Impact on
Requirements
|
Author |
Reviewer(s) |
PR |
---|---|---|---|---|---|
Fixing a couple of plots to use initial block height |
Fixing a couple of plots to use initial block heightt. |
NA: None of these plots of requirements. |
John Stilley |
Chris Keckler, Drew Johnson |
1998 |
Removing the HTML reports feature |
The ARMI HTML reports were never used, and they are currently broken, so they are being removed. |
NA |
John Stilley |
Tony Alberti |
2098 |
Fixing issue in copyInterfaceInputs with one file |
This fixes an edge case in copyInterfaceInputs() where there is a list of files to copy, but the list is only one element long. |
NA |
John Stilley |
Drew Johnson |
2102 |
fix side effects from tests |
Fix unintended unit test side effects. |
NA |
Alex James |
John Stilley |
2111 |
Adding Reactor construction hook to Database.load() |
Add beforeReactorConstruction hook to database loads. |
NA |
Alex James |
John Stilley, Arrielle Opotowsky |
2115 |
OperatorMPI doesn’t need to bcast quits if there no other workers |
Allow OperatorSnaphots.operate work with without optional mpi4py dependency. |
NA |
Drew Johnson |
John Stilley |
2129 |
Title |
Change |
Impact on
Requirements
|
Author |
Reviewer(s) |
PR |
---|---|---|---|---|---|
Speed up axial expansion unit tests |
Speeding up unit tests related to axial expansion. |
Very minor change to the tests associated with T_ARMI_ASSEM_HEIGHT_PRES and T_ARMI_INP_COLD_HEIGHT, in that I have sped them up. |
John Stilley |
Tony Alberti |
2093 |
Fixing spelling errors |
Fixing spelling errors found throughout the documentation and code comments. |
NA |
John Stilley |
jabari-max, Arrielle Opotowsky |
2096 |
Fixing spelling in docs and docstrings |
Fixing spelling errors in the ARMI docs and docstrings. |
NA |
John Stilley |
Tony Alberti |
2103 |
Removing defunct references to Cinder |
Remove references to an internally deprecated tool Cinder. |
N/A |
Tony Alberti |
John Stilley |
2104 |
Combining three .gitignore files into one |
Cleanup: I am combining three .gitignore files into one. |
NA |
John Stilley |
Tony Alberti |
2110 |
Cleaning up the codeTiming reports |
Cleaning up the codeTiming reports. |
NA |
John Stilley |
Tony Alberti, Arrielle Opotowsky |
2116 |
Reducing the warnings from Block.autoCreateSpatialGrids |
Reducing the warnings from Block.autoCreateSpatialGrids |
NA |
John Stilley |
Drew Johnson, Chris Keckler |
2117 |
Removing permanently skipped tests |
Removing permanently skipped tests. |
NA |
John Stilley |
Arrielle Opotowsky |
2123 |
Removing old TODO comments from the codebase |
Removing old TODO comments from the codebase |
NA |
John Stilley |
Arrielle Opotowsky |
2126 |
Removing 3 unused Settings |
Removing 3 unused Settings: customFuelManagementIndex, infiniteDiluteCutoff, and lowPowerRegionFraction. |
NA |
John Stilley |
Tony Alberti |
2127 |
Created a fast flux energy structure for calculating fast flux |
This change adds a new energy structure to be used by an application to calculate the fast flux fraction. |
NA |
Tommy Cisneros |
John Stilley |
2128 |
Removing unused Parameters |
We identified several parameters which were totally unused, and removed them. |
NA |
John Stilley |
Tony Alberti |
2130 |
Removing unused reactivity coeffs params |
Removing unused reactivity coefficients parameters. |
NA |
John Stilley |
Tony Alberti |
2132 |
Title |
Change |
Impact on
Requirements
|
Author |
Reviewer(s) |
PR |
---|---|---|---|---|---|
Adding an SCR section to the docs |
ARMI now has an automated “SCR” section, instead of a manual “Release Notes” section that has to be tweaked in code. |
NA |
John Stilley |
Arrielle Opotowsky |
2090 |
Edits to STR test report |
Several changes to the Software Test Report, to improve legibility. |
NA |
Arrielle Opotowsky |
John Stilley |
2095 |
Adding more info to STR intro |
Clarifying how ARMI requirements are met with unit tests. |
NA |
John Stilley |
Arrielle Opotowsky |
2100 |
Fixing issue with SCR on main branch |
Fixing an issue where the SCR is not generating correctly on the main branch, only on PRs. |
NA |
John Stilley |
Arrielle Opotowsky |
2101 |
Adding basic documentation for axial expansion |
Adding basic documentation for axial expansion |
NA |
John Stilley |
Tony Alberti, Chris Keckler |
2119 |
Update docstring for Settings class to reflect mutability |
Update the docstring for the Settings class to reflect their mutability |
None |
Chris Keckler |
John Stilley |
2131 |