4.1. SCR for ARMI 0.6.0
This is a listing of all the Software Change Request (SCR) changes in the ARMI repository, as part of release number 0.6.0.
Below, this SCR is organized into the individual changes that comprise the net SCR for this release. Each SCR below explicitly lists its impact on ARMI requirements, if any. It is also important to note ARMI and all its requirements are tested entirely by the automated testing that happens during the ARMI build. None of the SCRs below will be allowed to happen if any single test fails, so it can be guaranteed that all SCRs below have fully passed all testing.
4.1.1. SCR Listing
The following lists display all the SCRs in this release of the ARMI framework.
List of SCRs of type: Code Changes, Features
PR #1995: Improving HexBlock.getFlowArea
Change: The method HexBlock.getFlowArea() previously only accounted for regular coolant and not the inter-duct coolant.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Casey Stocking
PR #2031: Providing better composite iteration methods
Change: Provide ways for users and developers to traverse the composite tree without using lists.
Impact on Requirements: This very slightly simplifies the implementation I_ARMI_FLUX_COUPLING_VALUE, and very slightly touches the test T_ARMI_FLUX_COUPLING_VALUE. This also, very slightly, simplifies the implementation I_ARMI_ASSEM_DIMS1 and I_ARMI_CMP1 with the new tools this PR provides.
Author: Drew Johnson
Reviewer: John Stilley
PR #2045: Adding a check on the grid/component consistency in the BPs
Change: Adds a check on the grids associated with a block to ensure that the components that are supposed to be in the grid actually are, and in the correct number.
Impact on Requirements: This change very slightly touches the unit test T_ARMI_BP_GRID0 for the requirement R_ARMI_BP_GRID.
Author: Chris Keckler
Reviewer: John Stilley
PR #2092: Allowing ARMI to use tmp dir on Mac/Linux
Change: Moving from the home directory to the temp direction on Linux, for ARMI temp files.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2105: Removing support for XML geom files
Change: Removing support for archaic XML “geom files”, in favor of modern YAML blueprint files.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2106: Add Core.iterBlocks and Assembly.iterBlocks
Change: Adding Core.iterBlocks and Asssembly.iterBlocks for traversing grandchildren of a Core.
Impact on Requirements: A trivial implementation change to switch from getBlocks to iterBlocks in the tests for T_ARMI_MACRO_XS, T_ARMI_UMC_PARAM_BACKWARD0, T_ARMI_UMC_PARAM_BACKWARD1, T_ARMI_ROTATE_HEX_ASSEM, T_ARMI_ASSEM_BLOCKS, T_ARMI_R_SYMM, and T_ARMI_ADD_EDGE_ASSEMS.
Author: Drew Johnson
Reviewer: John Stilley
PR #2107: Handing empty string defaults better in copyInterfaceInputs
Change: Adding logic to copyInterfaceInputs to properly handle a file setting default that is an empty string.
Impact on Requirements: NA
Author: Arrielle Opotowsky
Reviewer: John Stilley
PR #2109: Store number densities in numpy arrays instead of dictionary
Change: Change component number density storage from dictionary to numpy arrays.
Impact on Requirements: NA
Author: Michael Jarrett
Reviewer(s): John Stilley, Drew Johnson
PR #2114: Allowing component area to be queried at arbitrary temp
Change: Allow calculation of component area at arbitrary temperature
Impact on Requirements: NA
Author: Alex James
Reviewer: John Stilley
PR #2118: Adding a FilletedHexagon shape
Change: Adding a FilletedHexagon shape, which is just a hexagon with rounded corners.
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): dlangewisch, Chris Keckler, Alex James
PR #2121: Supporting growing DBto full core on db load
Change: The setting growToFullCoreAfterLoad is used to expand the reactor to full core when loading from a database.
Impact on Requirements: Functionality added to I_ARMI_DB_TIME1 the implementation of R_ARMI_DB_TIME
Author: Drew Johnson
Reviewer: John Stilley
PR #2135: Retooling single-warnings report as all warnings report
Change: Retooling the old de-duplicated-warnings-report with a new all-warnings-report.
Impact on Requirements: Trivial tweaks of I_ARMI_LOG_MPI for R_ARMI_LOG_MPI. Improving test T_ARMI_LOG2 for R_ARMI_LOG.
Author: John Stilley
Reviewer(s): Tony Alberti, Arrielle Opotowsky
PR #2138: Allowing the BOL orientations to be set in the blueprints
Change: Allowing the BOL orientations to be set in the blueprints
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): Alex James, Chris Keckler
PR #2162: Make axial linking aware of block grids for axial expansion
Change: Enable multi-pin component support for axial expansion.
Impact on Requirements: NA
Author: Tony Alberti
Reviewer(s): Drew Johnson, John Stilley
PR #2173: Improving Core.libs to look for the current cycle and node
Change: Improving Core.libs to look for the current cycle and node.
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): Arrielle Opotowsky, Mark Onufer
PR #2175: Blocking duplicate flags from being added
Change: Blocking duplicate flags from being added.
Impact on Requirements: Changes the implementation I_ARMI_FLAG_EXTEND0 of R_ARMI_FLAG_EXTEND, so that if someone tries to add a flag that already exists, it is silently ignored.
Author: John Stilley
Reviewer: Alex James
PR #2198: Updating Axial Expansion Changer for improved mass redistribution
Change: New axial expansion changer that manually redistributes mass.
Impact on Requirements: Minor change to the implementation I_ARMI_INP_COLD_HEIGHT for R_ARMI_INP_COLD_HEIGHT and major change to the implementation I_ARMI_ASSEM_HEIGHT_PRES for R_ARMI_ASSEM_HEIGHT_PRES; adding logic for block-level mass redistribution.
Author: Tony Alberti
Reviewer(s): Drew Johnson, John Stilley, Michael Jarrett
PR #2199: Add 3 nuclides to getDefaultNuclideFlags
Change: Add 3 nuclides to getDefaultNuclideFlags
Impact on Requirements: No impact to requirements
Author: Arrielle Opotowsky
Reviewer: John Stilley
PR #2202: Provide Component.pinIndices for helping understand where pins are
Change: Provides Block.assignPinIndices which is responsible for setting the new Component.p.pinIndices parameter.
Impact on Requirements: NA
Author: Drew Johnson
Reviewer: John Stilley
PR #2208: Making ParamMapper symmetry-aware
Change: ParamMapper now converts volume integrated parameters to full size when getting parameters (when appropriate), and converts parameters to partial size when setting parameters (when appropriate).
Impact on Requirements: NA
Author: Brian Sculac
Reviewer: Michael Jarrett
PR #2209: Block collection nuclides
Change: reduce the number of nuclides stored on each component in a representative block by ignoring those with 0.0 number density.
Impact on Requirements: NA
Author: Michael Jarrett
Reviewer: John Stilley
PR #2218: Adding a method to get cycle/node combinations for a time interval
Change: Adding a small utility method to get a list of cycle/node combinations for a given time interval.
Impact on Requirements: This is a small change to I_ARMI_DB_H5 for R_ARMI_DB_H5, in that we added code. But this is just an added convenience utility to safe users doing math, it does not meaningfully change the Database interface.
Author: John Stilley
Reviewer: Mark Onufer
PR #2219: Refactoring Shuffle Logic Inputs to YAML
Change: Implement YAML shuffle file input with ability to manually rotate individual assemblies.
Impact on Requirements: NA
Author: Hunter Smith
Reviewer(s): Drew Johnson, John Stilley
PR #2221: Update logic for number density arrays and other cleanup
Change: Updates to handling of reactor parameters and nuclides to enable new downstream uses cases for the uniform mesh converter.
Impact on Requirements: NA
Author: Michael Jarrett
Reviewer: John Stilley
PR #2223: Move the zonesFile setting to the framework and add building of zones to the interface stack
Change: Allow users to specify zones in a separate yaml file, and add zone construction to the interface stack
Impact on Requirements: NA
Author: Chris Keckler
Reviewer(s): John Stilley, Arrielle Opotowsky
PR #2225: Advancing r.p.time in the Operator
Change: Advancing r.p.time in the Operator.
Impact on Requirements: Added I_ARMI_DB_TIME2 to the R_ARMI_DB_TIME requirement, pointing out that in order for the database to record the time, the operator must generate it.
Author: John Stilley
Reviewer: Chris Keckler
PR #2227: Symmetry testing
Change: Add test fixture to allow plugins to check if parameters are symmetry-aware.
Impact on Requirements: NA
Author: Brian Sculac
Reviewer(s): Drew Johnson, John Stilley, Michael Jarrett, Arrielle Opotowsky
PR #2233: Remove axialPowerProfile* parameters
Change: Remove axialPowerProfile* parameters
Impact on Requirements: N/A
Author: Drew Johnson
Reviewer: John Stilley
PR #2235: Adding two geometry parameters
Change: Adding guideTubeTopElevation dimension to HoledHexagon and adding holeRadFromCenter parameter to assembly.
Impact on Requirements: Adding optional complexity to I_ARMI_COMP_SHAPES for R_ARMI_COMP_SHAPES, so analysts can increase the fidelity of their downstream modeling.
Author: John Stilley
Reviewer: Alex James
PR #2243: Updating wetted perimeter calculation
Change: Updating the getWettedPerimeter function for blocks with multiple pin types.
Impact on Requirements: NA
Author: Casey Stocking
Reviewer(s): Tony Alberti, John Stilley
PR #2251: Comparing special formatting parameters in DBs
Change: Datasets with differences in special formatting parameters (e.g., jagged arrays) will now be considered a diff
Impact on Requirements: NA
Author: Drew Johnson
Reviewer: John Stilley
PR #2255: Add b10NumFrac attribute to B4C class to allow for flexible setDefaultMassFracs
Change: Add b10NumFrac attribute to B4C class to allow for flexible setDefaultMassFracs
Impact on Requirements: NA
Author: Arrielle Opotowsky
Reviewer(s): John Stilley, Jake Hader
PR #2266: Allow assembly parameters to be symmetry aware during core transformations and move operations
Change: Enable parameter expansion based on symmetry for assembly parameters.
Impact on Requirements: NA
Author: Brian Sculac
Reviewer: Michael Jarrett
PR #2269: Track assemblies if discharged to SFP
Change: Enhance fuel handling logic to support flexible assembly discharge destinations and update documentation accordingly.
Impact on Requirements: NA
Author: Hunter Smith
Reviewer(s): Drew Johnson, John Stilley
PR #2272: Adding new Component param enrichmentBOL
Change: Add component level enrichmentBOL parameter.
Impact on Requirements: NA
Author: Hunter Smith
Reviewer(s): Drew Johnson, John Stilley
PR #2275: Cleaning internal state out of some materials
Change: Cleaning internal state out of some materials.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2277: Enhance fuel handler logic to support module imports
Change: Enhance fuel handler logic to support module imports
Impact on Requirements: NA
Author: Hunter Smith
Reviewer(s): John Stilley, Michael Jarrett
PR #2278: Adding support for moving assemblies from SFP to Core in YAML shuffle input
Change: Adding support for moving assemblies from SFP to Core in YAML shuffle input.
Impact on Requirements: NA
Author: Hunter Smith
Reviewer: John Stilley
PR #2292: Support mixed Blocks for smear density calculation
Change: Fix the Block.getSmearDensity() calculation for assemblies with multiple different types of clad and/or fuel components.
Impact on Requirements: NA
Author: Michael Jarrett
Reviewer(s): John Stilley, Tony Alberti
PR #2305: Raising error if no driverBlock is found by latticePhysicsWriter
Change: Throw an error when a user requests a driver material for a lattice physics input but none is found.
Impact on Requirements: NA
Author: Michael Jarrett
Reviewer: John Stilley
List of SCRs of type: Code Changes, Bugs and Fixes
PR #1654: Use clearer input syntax for hexagonal lattice pitch
Change: Added an option for a user to specify a hexagonal pitch directly in the blueprints.
Impact on Requirements: None.
Author: Michael Jarrett
Reviewer(s): John Stilley, Chris Keckler
PR #1998: Fixing a couple of plots to use initial block height
Change: Fixing a couple of plots to use initial block heightt.
Impact on Requirements: NA: None of these plots of requirements.
Author: John Stilley
Reviewer(s): Chris Keckler, Drew Johnson
PR #2098: Removing the HTML reports feature
Change: The ARMI HTML reports were never used, and they are currently broken, so they are being removed.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Tony Alberti
PR #2102: Fixing issue in copyInterfaceInputs with one file
Change: This fixes an edge case in copyInterfaceInputs() where there is a list of files to copy, but the list is only one element long.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Drew Johnson
PR #2111: fix side effects from tests
Change: Fix unintended unit test side effects.
Impact on Requirements: NA
Author: Alex James
Reviewer: John Stilley
PR #2115: Adding Reactor construction hook to Database.load()
Change: Add beforeReactorConstruction hook to database loads.
Impact on Requirements: NA
Author: Alex James
Reviewer(s): John Stilley, Arrielle Opotowsky
PR #2120: Cylindrical Cross Section model updates
Change: Updates to the CylindricalComponentsAverageBlockCollection representative block temperature treatment and the HexComponentsToCylConverter.
Impact on Requirements: Implementations for R_ARMI_BLOCKCONV_HEX_TO_CYL and R_ARMI_XSGM_CREATE_REPR_BLOCKS are being updated.
Author: Michael Jarrett
Reviewer(s): Drew Johnson, John Stilley
PR #2129: OperatorMPI doesn’t need to bcast quits if there no other workers
Change: Allow OperatorSnaphots.operate work with without optional mpi4py dependency.
Impact on Requirements: NA
Author: Drew Johnson
Reviewer: John Stilley
PR #2153: Hiding duplicate warning messages
Change: Hiding duplicate warning messages.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Michael Jarrett
PR #2160: Fixing bad Return in safeCopy
Change: Fixing the method safeCopy() there was an invalid keyword Return, which should have been return.
Impact on Requirements: This is a low-level file system tool and could technically affect lots of unit tests by making them fail. But the only requirement that is directly affected is R_ARMI_XSGM_FREQ because safeCopy is used in the implementation of I_ARMI_XSGM_FREQ3.
Author: John Stilley
Reviewer(s): Aaron Reynolds, Arrielle Opotowsky
PR #2163: Using gamma groups instead of neutron groups in gamiso.addDummyNuclidesToLibrary
Change: Alter loop in gamiso.addDummyNuclidesToLibrary to use gamma groups instead of neutron groups.
Impact on Requirements: NA
Author: Arrielle Opotowsky
Reviewer(s): John Stilley, Aaron Reynolds
PR #2176: Using np.int32 when reading GEODST files
Change: Use a numpy.int32 when reading GEODST files.
Impact on Requirements: R_ARMI_NUCDATA_GEODST holds the requirement to read a GEODST file.
Author: Drew Johnson
Reviewer: John Stilley
PR #2180: Remove assert statements from FilletedHexagon instantiation.
Change: Remove assert statements in the FilletedHexagon instantiation.
Impact on Requirements: NA
Author: Michael Jarrett
Reviewer: John Stilley
PR #2186: Ensuring full core BPs aren’t converted like 1/3 core
Change: Ensuring full core BPs aren’t converted like 1/3 core
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): Chris Keckler, Michael Jarrett
PR #2187: Fixing bug in Uranium.pseudoDensity
Change: Fixing bug in Uranium.pseudoDensity, it was incorrectly always zero.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Chris Keckler
PR #2189: Fixing bug in finding ISOTXS libraries to merge
Change: Fix a bug where a full file path was compared to a file name only.
Impact on Requirements: NA
Author: Michael Jarrett
Reviewer: John Stilley
PR #2191: Fixing issue with full core BP geometry conversion
Change: Fixing issue with full core BP geometry conversion
Impact on Requirements: NA
Author: John Stilley
Reviewer: Chris Keckler
PR #2195: Fixing round trip of hex lattice maps
Change: Fixing round trip of hex lattice maps
Impact on Requirements: NA
Author: John Stilley
Reviewer: Michael Jarrett
PR #2226: Fix equality of MultiIndexLocator and CoordinateLocation
Change: Fix equality of MultiIndexLocator and CoordinateLocation
Impact on Requirements: Strengthens behavior related to R_ARMI_GRID_MULT but does not directly modify that requirement.
Author: Drew Johnson
Reviewer: John Stilley
PR #2228: Fixing bug in Air.pseudoDensity when given Celsius T
Change: Fixing bug in Air.pseudoDensity when given Celsius temperature.
Impact on Requirements: NA
Author: Tony Alberti
Reviewer: John Stilley
PR #2229: Change initialization of modArea for database load
Change: change Component dimension initialization value from 0 to None in layout.py.
Impact on Requirements: NA
Author: Michael Jarrett
Reviewer: John Stilley
PR #2231: Fixing issue initial time node in previous PR
Change: Follow up fix to last PR (BOL time nodes)
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): Arrielle Opotowsky, Chris Keckler
PR #2236: Handle pinIndices for blocks that don’t have fuel
Change: Assign pinIndices to clad components if there are no fuel nor control components
Impact on Requirements: NA
Author: Drew Johnson
Reviewer(s): John Stilley, Michael Jarrett
PR #2245: Fixing invalid any() signature
Change: Fixing invalid any() signature
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): Chris Keckler, Michael Jarrett
PR #2248: Fixing issue loading from snapshots database
Change: Update envGroup on blocks from blueprints assemblies.
Impact on Requirements: NA
Author: Michael Jarrett
Reviewer: John Stilley
PR #2253: Making a unit test thread safe
Change: Make a parameter location edit in a test use a context manager with a parameter mock to avoid altering the global state of the parameter collection, resulting in a thread-safe test.
Impact on Requirements: None
Author: Brian Sculac
Reviewer: John Stilley
PR #2259: Re-assigning pin indices when sorting a Block
Change: Re-assigning pin indices when sorting a Block
Impact on Requirements: NA
Author: Drew Johnson
Reviewer: John Stilley
PR #2260: Fixing compareLines so that it doesn’t trip on zeros
Change: Fixing compareLines() so that it doesn’t trip on zeros
Impact on Requirements: NA
Author: Chris Keckler
Reviewer(s): John Stilley, Drew Johnson
PR #2268: Fixing Uranium enrichment calculations
Change: Consider all uranium isotopes in the enrichment calculation.
Impact on Requirements: NA
Author: Michael Jarrett
Reviewer: John Stilley
PR #2276: Fixing Composite.extend to correctly set the parent
Change: Fixing Composite.extend to correctly set the parent.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Drew Johnson
PR #2282: Fixing incorrect variable name in Pitch class
Change: Fixing incorrect variable name in Pitch class.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Chris Keckler
PR #2291: Conserve molesHmBOL / massHmBOL when performing axial expansion
Change: Fix conservation of component-level HM parameters in multipin axial expansion.
Impact on Requirements: Editing the implementation I_ARMI_ASSEM_HEIGHT_PRES for R_ARMI_ASSEM_HEIGHT_PRES to better handle BOL parameters.
Author: Michael Jarrett
Reviewer(s): Drew Johnson, John Stilley, Tony Alberti
PR #2294: Ensuring settings file can be found when writing one DB from another
Change: Allow reactors loaded from a database to be written to a working database file.
Impact on Requirements: NA
Author: Alex James
Reviewer(s): John Stilley, Chris Keckler
PR #2298: Preserve loading of CoordinateLocation in db load
Change: Recover any CoordinateLocation spatial locators during DB load
Impact on Requirements: Correct behavior during DB load covered by R_ARMI_DB_TIME
Author: Drew Johnson
Reviewer: John Stilley
PR #2302: Handle pin indices for fuel + non fuel on the same grid
Change: Support Component.pinIndices for fuel + non-fuel pins in the same Block.
Impact on Requirements: NA
Author: Drew Johnson
Reviewer(s): John Stilley, Michael Jarrett
PR #2307: Clearing out Component.p.pinIndices prior to assignment
Change: Clear out Component.p.pinIndices prior to assignment
Impact on Requirements: NA
Author: Drew Johnson
Reviewer(s): John Stilley, Michael Jarrett
List of SCRs of type: Code Changes, Maintenance, or Trivial
PR #1386: Improve “smallRun” settings names
Change: Changing the names of some rarely used settings to be more explicit and useful
Impact on Requirements: NA
Author: Tony Alberti
Reviewer: John Stilley
PR #2085: Dropping black formatter for ruff
Change: I dropped the black linter from the project and switched to using ruff.
Impact on Requirements: Many requirements will be touched in a very trivial way: their whitespace may change very slightly.
Author: John Stilley
Reviewer(s): Nick Touran, Arrielle Opotowsky
PR #2093: Speed up axial expansion unit tests
Change: Speeding up unit tests related to axial expansion.
Impact on Requirements: Very minor change to the tests associated with T_ARMI_ASSEM_HEIGHT_PRES and T_ARMI_INP_COLD_HEIGHT, in that I have sped them up.
Author: John Stilley
Reviewer: Tony Alberti
PR #2096: Fixing spelling errors
Change: Fixing spelling errors found throughout the documentation and code comments.
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): jabari-max, Arrielle Opotowsky
PR #2103: Fixing spelling in docs and docstrings
Change: Fixing spelling errors in the ARMI docs and docstrings.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Tony Alberti
PR #2104: Removing defunct references to Cinder
Change: Remove references to an internally deprecated tool Cinder.
Impact on Requirements: N/A
Author: Tony Alberti
Reviewer: John Stilley
PR #2110: Combining three .gitignore files into one
Change: Cleanup: I am combining three .gitignore files into one.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Tony Alberti
PR #2116: Cleaning up the codeTiming reports
Change: Cleaning up the codeTiming reports.
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): Tony Alberti, Arrielle Opotowsky
PR #2117: Reducing the warnings from Block.autoCreateSpatialGrids
Change: Reducing the warnings from Block.autoCreateSpatialGrids
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): Drew Johnson, Chris Keckler
PR #2123: Removing permanently skipped tests
Change: Removing permanently skipped tests.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2126: Removing old TODO comments from the codebase
Change: Removing old TODO comments from the codebase
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2127: Removing 3 unused Settings
Change: Removing 3 unused Settings: customFuelManagementIndex, infiniteDiluteCutoff, and lowPowerRegionFraction.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Tony Alberti
PR #2128: Created a fast flux energy structure for calculating fast flux
Change: This change adds a new energy structure to be used by an application to calculate the fast flux fraction.
Impact on Requirements: NA
Author: Tommy Cisneros
Reviewer: John Stilley
PR #2130: Removing unused Parameters
Change: We identified several parameters which were totally unused, and removed them.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Tony Alberti
PR #2132: Removing unused reactivity coeffs params
Change: Removing unused reactivity coefficients parameters.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Tony Alberti
PR #2133: Moving NeutronicsPlugin to its own file
Change: Moving NeutronicsPlugin to its own file.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Tony Alberti
PR #2134: Removing unused Parameters
Change: Removing unused parameters, particularly relating to depletion and equilibrium.
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): Arrielle Opotowsky, Tony Alberti
PR #2136: Removing unused TH parameters.
Change: Removing unused thermal hydraulics parameters.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2139: Removing unnecessary DB load try/except
Change: Removing unnecessary DB load try/except
Impact on Requirements: Hypothetically, this touches I_ARMI_DB_TIME1. However, all we are doing here is removing unused code. So there will be no noticeable effect.
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2140: Cleaning up Block constructor
Change: Removing old, defunct code from Block constructor.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2141: Changing format-style strings to f-strings
Change: Swapping out old format-based strings with f-strings.
Impact on Requirements: NA
Author: Tony Alberti
Reviewer: John Stilley
PR #2142: Quieting warnings from Block.getComponent
Change: Reducing warning output from getComponent
Impact on Requirements: None
Author: Alex James
Reviewer: John Stilley
PR #2144: Improving the default value for Assembly.getArea()
Change: Improving the default value for Assembly.getArea()
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): Tony Alberti, Arrielle Opotowsky
PR #2146: Some more fstring conversions
Change: Swapping out old format-based strings with f-strings.
Impact on Requirements: NA
Author: Tony Alberti
Reviewer: John Stilley
PR #2155: Cleaning up strange counter line
Change: Cleaning out a strange counter increment in the plugin manager.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2157: Removing overly-specific check from the Component constructor
Change: Removing overly-specific check from the Component constructor.
Impact on Requirements: We are removing code we don’t like from I_ARMI_COMP_DEF, which implements R_ARMI_COMP_DEF. But this is a very minor clean-up type change. That feature will remain unchanged in practice.
Author: John Stilley
Reviewer: Chris Keckler
PR #2165: Removing old setting mpiTasksPerNode from ZPPR test file
Change: Removing old setting mpiTasksPerNode from ZPPR test file.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Chris Keckler
PR #2166: Removing commented out code
Change: Removing code that was commented out.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Tony Alberti
PR #2167: Removing unused test code
Change: Cleaning out unused test code.
Impact on Requirements: NA
Author: Tony Alberti
Reviewer: John Stilley
PR #2168: Removing Deprecation Warning on sortReactor setting
Change: Removing Deprecation Warning on sortReactor setting.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Chris Keckler
PR #2170: Adding a collar flag
Change: Adding a new flag for assemblies: COLLAR.
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): jyang-TP, Arrielle Opotowsky
PR #2171: Cleaning up Tests to have Fewer Side Effects
Change: Cleaning up a couple tests to have fewer side effects, so they can be run in any order.
Impact on Requirements: None
Author: Alex James
Reviewer: John Stilley
PR #2183: Renaming old smallRun Setting to rmExternalFilesAtEOL
Change: Renaming old smallRun Setting to rmExternalFilesAtEOL.
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): Tony Alberti, Arrielle Opotowsky
PR #2190: Using iterators instead of getAssemblies where possible
Change: Switching from Core.getAssemblies() to Core.__iter__() where possible.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Drew Johnson
PR #2197: Using iterators more in our unit tests
Change: Using iterators more in our unit tests
Impact on Requirements: NA
Author: John Stilley
Reviewer: Drew Johnson
PR #2203: Slight refactor on b.getSmearDensity to accommodate downstream work
Change: Refactor block.getSmearDensity to allow users to provide an explicit list of components rather than relying on the block itself.
Impact on Requirements: NA
Author: Tony Alberti
Reviewer: Arrielle Opotowsky
PR #2210: Removing python-dateutil dependency
Change: Removing python-dateutil dependency
Impact on Requirements: NA
Author: John Stilley
Reviewer: Brian Sculac
PR #2211: Remove Component.p.puFrac
Change: Remove Component.p.puFrac
Impact on Requirements: NA
Author: Drew Johnson
Reviewer: John Stilley
PR #2212: Removing duplicate lines
Change: Removing redundant lines.
Impact on Requirements: NA
Author: Michael Jarrett
Reviewer(s): Drew Johnson, John Stilley
PR #2215: Removing defunct deprecation warning
Change: Removing defunct deprecation warning from the unsorted reactor settings.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2220: Adding a basic unit test of Block.computeSmearDensity
Change: Adding a basic test of Block.computeSmearDensity
Impact on Requirements: NA
Author: John Stilley
Reviewer: Tony Alberti
PR #2230: Adding Composite.getFirstComponent method
Change: Adding Composite.getFirstComponent method
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): Drew Johnson, Casey Stocking
PR #2232: Handling BOL times better
Change: Ensuring that at BOL the default value of r.p.time = 0 is written to the database.
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): Chris Keckler, Arrielle Opotowsky
PR #2240: Cleaning trace and profile out of RunEntryPoint
Change: Cleaning trace and profile out of RunEntryPoint
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2241: move attributes to __init__
Change: Change class attributes to be assigned in __init__ rather than at the class level to prevent potential problems with namespace pollution.
Impact on Requirements: None
Author: Brian Sculac
Reviewer(s): Arrielle Opotowsky, Drew Johnson
PR #2242: ParamLocation for Duct Temp/DPAs
Change: Updating ParamLocation on several block params to align with the quantities that are being calculated and stored by the neutronics and thermal-hydraulics teams
Impact on Requirements: NA
Author: Jason Meng
Reviewer(s): John Stilley, Arrielle Opotowsky
PR #2246: Bumping ARMI to 0.6.0
Change: Bumping ARMI to 0.6.0
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2257: Improving Code Coverage for Blocks and MPIAction
Change: Improving Code Coverage for Blocks and MPIAction
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2263: Adding tests to improve code coverage
Change: Adding tests to improve code coverage.
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): Arrielle Opotowsky, Drew Johnson
PR #2265: Removing deprecated settingsValidation file
Change: Removing deprecated settingsValidation file.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2283: Removing unused debugDB setting
Change: Removing unused debugDB setting.
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): Drew Johnson, Arrielle Opotowsky
PR #2285: Improving the error messages for invalid settings data
Change: Improving the error messages for invalid settings data.
Impact on Requirements: Minor change to improve I_ARMI_SETTINGS_DEFAULTS for requirement I_ARMI_SETTINGS_DEFAULTS, essentially just turning an internal variable into a setter/getter property.
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2289: Improving extensibility of mass redistribution method in axial expansion
Change: Improve extensibility of the axial expansion changer.
Impact on Requirements: NA
Author: Tony Alberti
Reviewer(s): John Stilley, Drew Johnson
PR #2297: Reducing log spam when creating a lot of spatial grids
Change: Reducing log spam when creating spatial grids.
Impact on Requirements: Minor logging change to I_ARMI_BP_GRID for R_ARMI_BP_GRID.
Author: John Stilley
Reviewer: Drew Johnson
PR #2300: Shortening our longest unit test names
Change: Shortening our longest unit test names.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
List of SCRs of type: Documentation-Only Changes
PR #2090: Adding an SCR section to the docs
Change: ARMI now has an automated “SCR” section, instead of a manual “Release Notes” section that has to be tweaked in code.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2095: Edits to STR test report
Change: Several changes to the Software Test Report, to improve legibility.
Impact on Requirements: NA
Author: Arrielle Opotowsky
Reviewer: John Stilley
PR #2100: Adding more info to STR intro
Change: Clarifying how ARMI requirements are met with unit tests.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2101: Fixing issue with SCR on main branch
Change: Fixing an issue where the SCR is not generating correctly on the main branch, only on PRs.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2119: Adding basic documentation for axial expansion
Change: Adding basic documentation for axial expansion
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): Tony Alberti, Chris Keckler
PR #2131: Update docstring for Settings class to reflect mutability
Change: Update the docstring for the Settings class to reflect their mutability
Impact on Requirements: None
Author: Chris Keckler
Reviewer: John Stilley
PR #2137: Improving description of rateProdNet parameter
Change: Improving descriptiion of rateProdNet parameter,
Impact on Requirements: NA
Author: John Stilley
Reviewer: Drew Johnson
PR #2143: Improving the docs-build instructions
Change: Improving the docs-build instructions
Impact on Requirements: NA
Author: John Stilley
Reviewer: Tony Alberti
PR #2148: Adding tooling to help people build the docs locally
Change: Adding tooling so that people can more easily build the docs locally.
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): Arrielle Opotowsky, Tony Alberti
PR #2150: Clarifying setting disableBlockTypeExclusionInXsGeneration
Change: Clarifying the setting disableBlockTypeExclusionInXsGeneration.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Drew Johnson
PR #2151: Adding SQA for the SFP and cycles setting
Change: Adding SQA for the SpentFuelPool and the setting “cycles”.
Impact on Requirements: Added the requirement R_ARMI_SFP to cover the SpentFuelPool feature. And added more testing of the “cycles” setting to R_ARMI_FW_HISTORY.
Author: John Stilley
Reviewer: Chris Keckler
PR #2174: Remove traces of black
Change: Ensuring the software attributes in the ARMI docs are up to date with current practices.
Impact on Requirements: NA
Author: Tony Alberti
Reviewer: John Stilley
PR #2213: Ensuring non-main branch PRs do not yield SCRs
Change: Ensuring the non-main branch PRs do not yield SCRs.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Drew Johnson
PR #2214: Fixing error in recent doc change
Change: Fixing error in recent doc change.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Drew Johnson
PR #2217: Improving documentation of axial expansion
Change: Improving documentation of axial expansion
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): Casey Stocking, Tony Alberti
PR #2222: Make a duplicated test tag unique
Change: Make a duplicated test tag unique
Impact on Requirements: Updated test tags for R_ARMI_BP_GRID
Author: Drew Johnson
Reviewer: John Stilley
PR #2238: Trying to speed up docs build
Change: Trying to speed up docs build
Impact on Requirements: NA
Author: John Stilley
Reviewer(s): Arrielle Opotowsky, Drew Johnson
PR #2249: Improving docs on entry points creation
Change: Improving docs on entry points creation.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2264: Update the description of the mcnpLibraryVersion case setting
Change: Update the description of the mcnpLibraryVersion case setting
Impact on Requirements: NA
Author: Chris Keckler
Reviewer: John Stilley
PR #2270: Fixing sphinx warnings in the doc build
Change: Fixing sphinx warnings in the doc build
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2274: Adding user documentation of core symmetry
Change: Add a section to the user manual describing how symmetry is handled, primarily for the thirdToFullHexCoreChanger.
Impact on Requirements: NA
Author: Brian Sculac
Reviewer: John Stilley
PR #2279: Fixing the SCR table in the docs
Change: Fixing the SCR table so it shows the full SCR list for the current release, no just the most recent single SCR.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky
PR #2286: Improving Docs for 0.6.0 Release
Change: Improving Docs for 0.6.0 release, responding to reviewer comments.
Impact on Requirements: NA
Author: John Stilley
Reviewer: Arrielle Opotowsky