8. First Time Contributors Guide

The ARMI team strongly encourages developers to contribute to the codebase.

The ARMI framework code is open source, and your contributions will become open source. Although fewer laws apply to open source materials because they are publicly-available, you still must comply with all applicable laws and regulations.

8.1. Help Wanted

There are a lot of places you can get started to help the ARMI project and team:

  • Better Documenting ARMI

  • Better test coverage

  • Many more type annotations are desired. Type issues cause lots of bugs.

  • Targeted speedups (e.g. informed by a profiler)

  • Additional relevance to thermal reactors

Naturally, you can also look at the open ARMI issues to see what work needs to be done. In particular, check out the help wanted tickets and good first issue tickets.

8.2. Testing

Any contribution must pass all included unit tests. You will frequently have to fix tests your code changes break. And you should definitely add tests to cover anything new your code does.

The standard way to run the tests is to install and use tox:

$ pip install tox
$ tox -- -n 6

This runs the unit tests in parallel on 6 processes. Omit the -n 6 argument to run on a single process.

Or the tests can also be run using pytest directly:

$ pip intall -e .[test]
$ pytest -n 4 armi

8.3. Submitting Changes

To submit a change to ARMI, you will have to open a Pull Request (PR) on GitHub.com.

The process for opening a PR against ARMI goes something like this:

  1. Fork the ARMI repo

  2. Create a new branch in your repo

  3. Make your code changes to your new branch

  4. Submit a Pull Request against ARMIs main branch

    1. See GitHubs general guidance on Pull Requests

    2. See ARMIs specific guidance on what makes a “good” Pull Request: Tooling and Infrastructure.

  5. Actively engage with your PR reviewer’s questions and comments.

> Note that a bot will require that you sign our Contributor License Agreement before we can accept a pull request from you.

See our published documentation for a complete guide to our coding standards and practices: Standards and Practices for Coding.

Also, please check out our (quick) synopsis on good commit messages: Tooling and Infrastructure.

8.4. Licensing of Tools

Be careful when including any dependency in ARMI (say in the pyproject.toml file) not to include anything with a license that superceeds our Apache license. For instance, any third-party Python library included in ARMI with a GPL license will make the whole project fall under the GPL license. But a lot of potential users of ARMI will want to keep some of their work private, so we can’t allow any GPL tools.

For that reason, it is generally considered best-practice in the ARMI ecosystem to only use third-party Python libraries that have MIT or BSD licenses.